linutil icon indicating copy to clipboard operation
linutil copied to clipboard

Add tips box to display useful information

Open prschorn opened this issue 1 year ago • 8 comments

Pull Request

Title

Add tips box to display useful information

Type of Change

  • [x] New feature

Description

Adding a box on the top left corner to display useful information, at first, it displays the command to exit, but can be used to display state of installs, errors etc.

Testing

  • Tested navigation on all sub menus;
  • Tested state while installing packages;
  • Tested visual integrity before and after adding the display box;

Impact

  • Should have no impact in performance, as it's just a new visual text display;

Issue related to PR

  • resolves https://github.com/ChrisTitusTech/linutil/issues/235
  • resolves https://github.com/ChrisTitusTech/linutil/issues/236

Checklist

  • [x] My code adheres to the coding and style guidelines of the project.
  • [x] I have performed a self-review of my own code.
  • [x] My changes generate no errors/warnings/merge conflicts.

prschorn avatar Sep 05 '24 14:09 prschorn

@prschorn Can you squash those 3 redundant commits please?

ghost avatar Sep 06 '24 01:09 ghost

Conflicts with #241

@prschorn Maybe you should refactor this PR a bit to focus on one thing rather than many e.g. "Tips box to display useful information" Instead of showing the kill keybind.

ghost avatar Sep 06 '24 11:09 ghost

This might be better implemented as a float component. This was already a pretty light PR, so it shouldn't be too much work to refactor it that way and flesh it out a bit more

cartercanedy avatar Sep 06 '24 14:09 cartercanedy

@prschorn Can you squash those 3 redundant commits please?

Done

prschorn avatar Sep 06 '24 17:09 prschorn

This might be better implemented as a float component. This was already a pretty light PR, so it shouldn't be too much work to refactor it that way and flesh it out a bit more

How would that be displayed in a float component? Should it be visible any time or triggered by something else?

prschorn avatar Sep 06 '24 17:09 prschorn

I really liked where you were going with this, but I thought that just 1 tip is not enough, so I went a little overkill, and created #293 :)

JustLinuxUser avatar Sep 06 '24 21:09 JustLinuxUser

I really liked where you were going with this, but I thought that just 1 tip is not enough, so I went a little overkill, and created #293 :)

Really like this one, it's what I envisioned for the future, this first PR was to just start everything and new commands to be added in the future, but you did a lot already :) looks really nice

prschorn avatar Sep 06 '24 23:09 prschorn

Sorry for the inconvenience. We had a massive restructure of the codebase to improve future development. Because of this can you update your PR to the new structure. Thank you for your assistance and contribution.

ChrisTitusTech avatar Sep 12 '24 18:09 ChrisTitusTech