koler icon indicating copy to clipboard operation
koler copied to clipboard

wrong missed calls count in the notification

Open bagajohny opened this issue 4 years ago • 5 comments

Checklist

  • [x] I am using the latest version - 1.4.3
  • [x] I checked, but didn't find any duplicates (open OR closed) of this issue in the repo.
  • [x] This issue contains only one bug. I will open one issue for every bug report I want to file.

Steps to reproduce the bug

Actual behaviour

When you get a missed call, in the notification it shows wrong count for the no of missed calls. Here is the screenshot. As you can see, I got only 1 missed call today but in the notification it shows 8 missed calls. And I confirmed with the caller that he only called once.

My theory is that the missed calls count in the notification is the total no of missed calls I got since I installed Koler.

Expected behavior

The notification should show only the count of recent missed calls. It should show separate notification for missed calls from different callers. When you expand the notification you should get option to call or text the caller from the notification.

Screenshots/Screen recordings

image


image

Device info

  • Android version/Custom ROM version: stock android 12
  • Device model: Pixel 3a

bagajohny avatar Mar 30 '22 00:03 bagajohny

Thats not a bug. My guess is, since you use Koler and not the default dialer, you don't enter the default dialer to dismiss the missed call notification so it just sums up every time. Try to click that notification.

roeiedri avatar Mar 30 '22 05:03 roeiedri

Thats not a bug. My guess is, since you use Koler and not the default dialer, you don't enter the default dialer to dismiss the missed call notification so it just sums up every time. Try to click that notification.

When I click the notification nothing happens. The notification just disappears.

If this is not a bug then how do I solve the issue?

bagajohny avatar Mar 30 '22 07:03 bagajohny

I have that problem too. Whether it is bug or not - it is at least very confusing. Problem with Koler's reporting of missed call is that it does not says how many times you've missed the calls. Notification says you've call to THREE times but when I open Koler it still says just one.

I find lack of this very essential functionality that frustrating that I had to stop using Koler and go back to Google's default. :'(

ANDREW007CZ avatar Apr 04 '22 09:04 ANDREW007CZ

@roeiedri, this behavior is also present in Simple Dialer (https://github.com/SimpleMobileTools/Simple-Dialer/issues/256), and is partially caused by https://github.com/Chooloo/koler/issues/318.

A solution would be for the app itself to handle missed call notification in a similar manner as https://github.com/TinkerBoard2-Android/packages-apps-Car-Dialer/commit/ea074a2f527d4b9b3b5fd5ceafadba83c8b8ef13. Or, discover a way to properly signal to Telecom that missed calls have been handled (which may or may not be possible; I'm not sure whether Telecom's notifications are meant to be used by dialer apps, or if they are meant as a fallback for lack of a dialer app).

ghost avatar Apr 18 '22 22:04 ghost

@roeiedri try to take a look at this commit: https://github.com/android-dre/platform-packages-apps-Dialer/commit/cc42b5953588110cc89b43e72d2b6579757017a1

It is explained very superficially here too. What interests us is “Behavior in Android 7.0 and later”

https://source.android.com/devices/tech/connect/call-notification

Clav12 avatar May 29 '22 14:05 Clav12