nodejs-whisper icon indicating copy to clipboard operation
nodejs-whisper copied to clipboard

[Suggestion] Support for multiple models to exist

Open SimonRosengren opened this issue 1 year ago • 2 comments

I've noticed that there is a check for any model existing as part of the autoDownload. However, it only checks if there are > 0 models rather than checking if the autoDownloadModelName already exists.

if (existingModels.length > 0) {
	if (verbose) {
		console.log('[Nodejs-whisper] Models already exist. Skipping download.')
	}
	return 'Models already exist. Skipping download.'
}

It this by design or is it a bug? My suggestion would be to allow more than one model existing.

SimonRosengren avatar Jul 24 '24 13:07 SimonRosengren

I added a Pull Request for this as well in case you'd be interested

SimonRosengren avatar Jul 24 '24 14:07 SimonRosengren

@SimonRosengren Thanks for pointing out this issue. Yeah, initially it was by design, but I completely agree with you. I will review the PR soon.

ChetanXpro avatar Jul 30 '24 12:07 ChetanXpro

@SimonRosengren Merged the PR

ChetanXpro avatar Sep 03 '24 16:09 ChetanXpro