checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Make the agent work with Home Assistant OS

Open dnlldl opened this issue 1 year ago • 1 comments

General information

The current Linux agent doesn't work with Home Assistant OS (HAOS: https://www.home-assistant.io/installation/linux) because /bin/bash is in fact a redirection to /bin/sh. The openwrt agent is compatible with HAOS but doesn't provide as much information. It is notably missing the systemd agent information.

Proposed changes

To make the Linux agent work with sh, the <<< operators need to be replaced and the bash for loop syntax needs to be adapted as it is not compatible.

I am not sure what is the best approach to this as I don't have a variety of systems to test it on; it might break the agent on other systems although I didn't encounter any issue in my lab with my other Linux distros. A separate agent might be ideal but I admit we're entering a very niche OS that would not be worth supporting a completely total different agent. In that regard, it would probably be better for me to submit a new agent specifically for HAOS to the Checkmk Exchange, but I still wanted to leave a trace on the git and have your thoughts on the matter.

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

dnlldl avatar Jul 26 '24 06:07 dnlldl

there might be a problem with the read statements, this needs to be improved the bash agent is almost already sh compatible/compliant, I don't see any disadvantage to make it fully compatible, it can only benefit some older or more restricted systems

dnlldl avatar Sep 08 '24 07:09 dnlldl

Hi @dnlldl,

thank you for the contribution. I was looking at the changes and had to read up a bit on my shell scripting.

I think I figured out the issue with the read statement you mention. And I identified a little issue with the while loop, too.

I believe with these changes, the agent script should work correctly: agent-bash.patch.gz

Can you confirm, that these changes are also working for you?

crazyscientist avatar Feb 18 '25 12:02 crazyscientist