checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Support freebsd (OPNsense etc) for the included plugin isc_dhcpd

Open dnlldl opened this issue 1 year ago • 2 comments

Support freebsd (OPNsense etc)

Thank you for your interest in contributing to Checkmk! Consider looking into Readme regarding process details.

General information

This is to make the isc_dhcpd plugin work with any recent version of OPNsense.

Proposed changes

The dhcpd.leases file is in a different location than expected by the script. The command pidof doesn't exist and awk is also more limited.

root@OPNsense:~ # awk --version
awk version 20210215

This PR could be improved, using a configuration file instead of hardcoding the necessary files would be good. Also, for the pidof problem, which pidof could be used before falling back to something more universal with ps.

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

dnlldl avatar Jun 20 '24 01:06 dnlldl

is there any chance of this making it in eventually?

dnlldl avatar Sep 08 '24 07:09 dnlldl

I looked at it and approved it from a product perspective and forward it to a dev for analysis.

martinhv avatar Sep 17 '24 18:09 martinhv