Checkmk
Support freebsd (OPNsense etc) for the included plugin isc_dhcpd
Support freebsd (OPNsense etc)
Thank you for your interest in contributing to Checkmk! Consider looking into Readme regarding process details.
General information
This is to make the isc_dhcpd plugin work with any recent version of OPNsense.
Proposed changes
The dhcpd.leases file is in a different location than expected by the script. The command pidof doesn't exist and awk is also more limited.
root@OPNsense:~ # awk --version
awk version 20210215
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.
This PR could be improved, using a configuration file instead of hardcoding the necessary files would be good. Also, for the pidof problem, which pidof could be used before falling back to something more universal with ps.
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience.
Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see https://github.com/isaacs/github/issues/361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future.