checkmk icon indicating copy to clipboard operation
checkmk copied to clipboard

Add feature: auto-discovery for nvidia-smi on linux

Open mayrstefan opened this issue 1 year ago • 6 comments

General information

There is already support for nvidia-smi on Windows (see Werk 14723). This adds the same section to the linux agent if nvidia-smi is installed

Proposed changes

Add 'nvidia_smi' section to linux agent if nvidia-smi binary is found in path

mayrstefan avatar Mar 26 '24 22:03 mayrstefan

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Mar 27 '24 04:03 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

recheck

mayrstefan avatar Mar 27 '24 05:03 mayrstefan

recheck

mayrstefan avatar Mar 27 '24 18:03 mayrstefan

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

mayrstefan avatar Mar 27 '24 21:03 mayrstefan

recheck

mayrstefan avatar Mar 27 '24 21:03 mayrstefan

LGTM! 👏

jens-maus avatar Mar 31 '24 13:03 jens-maus

Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience.

TimotheusBachinger avatar Jun 19 '24 08:06 TimotheusBachinger

Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see https://github.com/isaacs/github/issues/361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future.

TimotheusBachinger avatar Jun 19 '24 13:06 TimotheusBachinger

@mayrstefan Please regenerate this PR so that it can be integrated into the main checkmk tree ASAP because it really improves things regarding nvidia-smi management for linux agents!

jens-maus avatar Jun 21 '24 10:06 jens-maus