ChatSecure-iOS icon indicating copy to clipboard operation
ChatSecure-iOS copied to clipboard

Changed certificate pinning to be optional

Open mimi89999 opened this issue 6 years ago • 4 comments

mimi89999 avatar May 10 '19 19:05 mimi89999

The ideal approach would disable the cert pinning module entirely, I have a work in progress here: https://github.com/ChatSecure/ChatSecure-iOS/commit/e4a46fd74e479943e4f3a681140ea3be9f7c84dd

However there are some issues with my approach, namely the cert pinning dialog no longer shows up consistently because (I think) of a race condition between lastConnectionError and loginStatus.

chrisballinger avatar May 16 '19 03:05 chrisballinger

Just want to confirm that in times of Let'sEncrypt certificates with short validity periods, these certificate re-verification warnings can be highly irritating and might train users to just click ok on everything.

schmittlauch avatar Jun 23 '19 11:06 schmittlauch

@chrisballinger Could you please finish implementing this? Currently I'm not able to work on OS X. I think that it's very important to have this feature added since many XMPP servers are using LE certificates and it's very annoying for users to click through this warning every 2 months. I could even pay to get this added.

mimi89999 avatar May 08 '20 15:05 mimi89999

@chrisballinger Could you please implement this?

mimi89999 avatar Feb 03 '21 18:02 mimi89999