NextChat icon indicating copy to clipboard operation
NextChat copied to clipboard

fix: fixed the conflict BUG between model thinking mode and line break parsing.

Open MagmaBlock opened this issue 8 months ago • 1 comments

💻 变更类型 | Change Type

  • [ ] feat
  • [x] fix
  • [ ] refactor
  • [ ] perf
  • [ ] style
  • [ ] test
  • [ ] docs
  • [ ] ci
  • [ ] chore
  • [ ] build

🔀 变更说明 | Description of Change

Resolves the issue where line breaks in model-generated reasoning content are not parsed correctly in the current version of NextChat. After this adjustment, all reasoning mode content will be properly enclosed within Markdown blockquotes.

📝 补充信息 | Additional Information

before and after:

53f2d3ad-45e4-479a-94d3-2be8e7e51020 076cd885-47e1-41e0-9771-1d679dbdb462 b31dda16-7c5c-4772-9850-624cc5c42a28 55725861-e877-4364-92a5-94445484cd86 0f3a1d76-51ec-4ac2-8dcd-214cc1a02eea 300e37fe0ae47bc119b70a1f27545d5c

Co-authored-by: MrrDrr [email protected] Co-authored-by: NakanoMiku39 [email protected]

Summary by CodeRabbit

  • Bug Fixes

    • Eliminated extra blank lines when entering “thinking” sections to prevent duplicated newlines.
  • Style

    • Improved readability of “thinking” content: each line is now uniformly quoted with “> ” for consistent multi-line formatting.
  • Other

    • No changes to normal chat rendering behavior.

MagmaBlock avatar Aug 27 '25 11:08 MagmaBlock

Walkthrough

Refines thinking-mode output formatting in streamWithThink within app/utils/chat.ts: conditional newline insertion before thinking blocks and consistent per-line quoting using a prefixed "> ". Removes prior special-casing of internal newlines. Adds a non-functional comment in a parse-error catch. Normal-mode logic unchanged.

Changes

Cohort / File(s) Summary of Edits
Thinking-mode quoting in streamWithThink
app/utils/chat.ts
- Insert newline before a thinking block only when remainText.length > 0 && !remainText.endsWith("\n").
- Quote thinking content by appending a standalone > line, then chunk.content with each newline replaced by \n> (uniform per-line quoting).
- Remove previous \n\n split/rejoin special-case.
- Add minor non-functional comment in parse-error catch.
- Normal-mode handling unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibble lines with careful cheer,
Adding > whispers, crisp and clear;
No double hops of stray newlines,
Each thought now marches, neat in signs.
Thump-thump! The stream looks quite succinct—
A rabbit’s quote, precisely inked. 🐇✍️

[!TIP]

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 27 '25 11:08 coderabbitai[bot]