material-github icon indicating copy to clipboard operation
material-github copied to clipboard

Issue titles invisible and repo name background white

Open ripdog opened this issue 4 years ago • 3 comments

Hi there, thanks for the stylesheet.

Looks like github has pushed an update. Screen Shot 2021-03-02 at 02 24 15-fullpage

As you can see Issue titles are the same colour as their backgrounds, and the background behind the repository name is white.

Also the page below the github footer is white.

ripdog avatar Feb 28 '21 13:02 ripdog

Just noticed that the comment buttons below the issue comment box (the one I'm typing in now) and the notice about attaching files are miscoloured. Also the title of the issue ('ripdog commented 1 minute ago') is miscoloured.

ripdog avatar Feb 28 '21 13:02 ripdog

If I may add to this: the grey text below the issues and in the pop-up that appears when hovering over the issue title are hard to read. The issue-link on hover appears dark blue on dark ground which is also a bit tricky.

As for fixes, issue titles become visible by changing text color for .Link--primary, .link-gray-dark and .Link--primary:hover, .link-gray-dark:hover , but I'm not sure (yet) if it will affect links in other places. ( :not(.IssueLabel) a:not(.IssueLabel) might be another option to play around with). The background for the repository name can be changed with .color-bg-secondary (but again, not sure, it'll affect other things). I didn't look into the pop-ups any further, so can't help with this one.

grafik

Nakonana avatar Feb 28 '21 21:02 Nakonana

This is because GitHub has added the light-and-dark theme setting, and changing this setting to darker theme resolved both the issues.

edit: grammar

tanujp99 avatar Apr 30 '21 09:04 tanujp99