solving issue #1355 - Mixed dependencies in the Storage Clients module for the Data Layer

[ndricca]

PR to handle issue #1355

I have added also a pytest for S3StorageClient and moto to mock aws connection. I am not so experienced with Azure so I did not add a test on it.

[hadarsharon]

Thanks for implementing this @ndricca 🥇

[ndricca]

i noticed that @dokterbob said

I imagine storage_clients module in the data module with a base.py and files for each implementation

while I was still using the base.py from parent folder, so i splitted also this script moving the base method into storage_clients submodule

[dokterbob]

Can't wait to review this (prolly around Wednesday in the coming week), unless @willydouhard beats me to it!

[ndricca]

@dokterbob am i suppose to push also the poetry.lock file? I see fails refer to this. I ran all poetry tests in local and they worked

[gsornsen]

Oh, nice! Looking forward to trying this out and dropping the need for a supervisor to start up moto-server and create a local s3 bucket in my current implementation.

[dokterbob]

@dokterbob am i suppose to push also the poetry.lock file? I see fails refer to this. I ran all poetry tests in local and they worked

We use the lockfile to make sure we're all dev'ing in exactly the same environment, creating more reproducible results.

[ndricca]

@dokterbob am i suppose to push also the poetry.lock file? I see fails refer to this. I ran all poetry tests in local and they worked

We use the lockfile to make sure we're all dev'ing in exactly the same environment, creating more reproducible results.

I have merged incoming commits from main and pushed poetry.lock, now it should work

[ndricca]

@dokterbob have you had any chance to read my last comments? Can you tell me what exactly do you want me to do about git commits and how to proceed so that we can close this issue?