lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Improve jsonRPC error UX for eth1 + execution

Open g11tech opened this issue 3 years ago • 1 comments

As brought to notice by a discord user seamonkey, sometimes because of the nodejs engine intermittent loading or the execution engine's intermittent loading the json rpc api can throw harmless intermittent errors like UNAVAILABLE, TIMEOUT like these

image

However these give users not so good experience, and hence we need to have an error accumulator for such unavailable errors and log the throw only if counter surpasses.

g11tech avatar Jul 27 '22 10:07 g11tech

will be picking this up

g11tech avatar Aug 18 '22 19:08 g11tech

@g11tech We already have a delay set for such cases of errors.

https://github.com/ChainSafe/lodestar/blob/6ac8c07023bc72c7ef54a6ea66884790793eda21/packages/beacon-node/src/eth1/eth1DepositDataTracker.ts#L182-L186

And the http errors UNAVAILABLE or TIMEOUT can actually be fatal. We can increase the wait time which is 1s right now, so such errors don't show a lot such errors in case the endpoint if momentarily not available. What do you think?

nazarhussain avatar Sep 05 '23 10:09 nazarhussain

@g11tech We already have a delay set for such cases of errors.

https://github.com/ChainSafe/lodestar/blob/6ac8c07023bc72c7ef54a6ea66884790793eda21/packages/beacon-node/src/eth1/eth1DepositDataTracker.ts#L182-L186

And the http errors UNAVAILABLE or TIMEOUT can actually be fatal. We can increase the wait time which is 1s right now, so such errors don't show a lot such errors in case the endpoint if momentarily not available. What do you think?

its not about wait time but sort of debounce the error .... like how we do for engine coming offfline online etc. so 1 error for state change

g11tech avatar Sep 07 '23 13:09 g11tech