zencoder-cs icon indicating copy to clipboard operation
zencoder-cs copied to clipboard

integer overflow issue (output Id)

Open RakheshHalis opened this issue 7 years ago • 0 comments

Hi Chad Burggraf, from last few days we are facing one issue. i.e integer overflow. please fix this.

please check this image for better understand.

https://lh3.googleusercontent.com/-kr0y-eC97lc/XD8YhLE-MYI/AAAAAAAAAKw/zvnIG87e3e8mj3jhzKP31I5r_AWjG6cLACL0BGAYYCw/h768/2019-01-16.png

https://github.com/ChadBurggraf/zencoder-cs/blob/master/Source/Zencoder/CreateJobResponse.cs open this file and go to line number 24. you can find public int Id { get; set; } this piece of line. "please change this to a long datatype".

'id' data type is an integer, the value is exceeded(2147483647<id) so, by default, it will consider as a 0.

when I pass this id '0' to JobProgressRequest method it will throw an exception "OutputId must be set before generating the request URL."

https://github.com/ChadBurggraf/zencoder-cs/blob/master/Source/Zencoder/JobProgressRequest.cs open this file and have a look at line number 67 and 69.

the solution is just to change the datatype of output id from int to long and also check all the possible scenarios. it will work.

Thanks.

RakheshHalis avatar Jan 16 '19 12:01 RakheshHalis