cesium icon indicating copy to clipboard operation
cesium copied to clipboard

Add `"WebGL"` to unit tests

Open j9liu opened this issue 3 years ago • 1 comments

This PR adds the missing "WebGL" keyword to various ModelExperimental specs for consistency with the rest of Cesium's unit tests.

j9liu avatar Jul 27 '22 15:07 j9liu

Thanks for the pull request @j9liu!

  • :heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

  • [ ] Cesium Viewer works.
  • [ ] Works in 2D/CV.

cesium-concierge avatar Jul 27 '22 15:07 cesium-concierge

@j9liu could you update this for the latest main? Then I can review this today.

ptrgags avatar Aug 15 '22 12:08 ptrgags

@ptrgags updated, I just redid my changes on top of the latest update on main. I left ModelDrawCommand and ClassificationModelDrawCommand untouched since those will be affected by #10716.

In addition to adding "WebGL" to all the specs, I also changed the variable names in I3dmLoaderSpec to be camelCase in accordance with the Coding Guide.

j9liu avatar Aug 23 '22 14:08 j9liu

Looks good, thanks @j9liu!

ptrgags avatar Aug 23 '22 15:08 ptrgags