clima icon indicating copy to clipboard operation
clima copied to clipboard

Chart titles do not display filter values correctly

Open phuongdoan13 opened this issue 2 years ago • 3 comments

This is an existing issues on all the chart with dynamic title with fitlers. The titles are not displaying the filtered values correctly. Consider these cases:

1. No filter on hour-range:

image

=> Title should be "... between 0:00 and 24:00"


2.Month-range and Hour-range with one point at either extreme end (Jan/Dec, 0/24). Invert is checked.

image

=> The Month-Range is [1, 9], inverted should be "... between the months of Oct and Dec"

=> Similarly, Hour-Range is [6, 24], inverted should be "... between the hours of 00:00 and 05:00"


3.Month-range and hour-range with no point at any extreme end. Invert is checked.

image

=> The Month-Range is [3, 10], inverted should be "... between the months of Nov and Feb"

=> Similarly, Hour-Range is [3, 21], inverted should be "... between the hours of 22:00 and 02:00"

Probable cause

https://github.com/CenterForTheBuiltEnvironment/clima/blob/f116b41fc6fc398dc7c26c506f3414a812a39925/my_project/utils.py#L321-L329

phuongdoan13 avatar May 11 '23 12:05 phuongdoan13

I think I have fixed the first sub-issue now the message is showing the right value, from 0 to 24.

I am not sure about point 2. If the user selects invert it should say which data are included in the analysis not the ones that are excluded. Could you please elaborate a bit more on this?

Could you please also elaborate more on point 3? I think that the two screenshot you took do not match.

FedericoTartarini avatar May 12 '23 05:05 FedericoTartarini

Hi Federico, thanks for your question. I just upated the description above

phuongdoan13 avatar May 14 '23 01:05 phuongdoan13

Hi, @phuongdoan13 could you please check if point one is solved? If so could you please remove it from the issue?

FedericoTartarini avatar May 15 '23 01:05 FedericoTartarini