osf.io
osf.io copied to clipboard
CenterForOpenScience
[ENG-1747] Upgrade GitHub3.py library to 1.3.0
Purpose
We are currently on 1.0.0a, which was released in 2016. We really should upgrade.
Changes
Modified addons/github/requirements.txt to include most recent version (1.3.0). Added user scope to settings. Modified a bunch of tests to include a mocked session, which is now required for the from_json method.
QA Notes
- Does this change require a data migration? If so, what data will we migrate? No
- What is the level of risk?
High, please test all GitHub related functionality.
- Any permissions code touched? No
- Is this an additive or subtractive change, other? Modification
- How can QA verify? (Through UI, API, AdminApp or AdminAdminApp?)
UI
- If verifying through API, what's the new version? Please include the endpoints in PR notes or Dev docs. N/A
- What features or workflows might this change impact? GitHub addon
- How will this impact performance? Shouldn't -->
Documentation
N/A
Side Effects
Shouldn't be.
Ticket
https://openscience.atlassian.net/browse/ENG-1747
@corbinSanders oops! one more thing can you see if you can remove these lines there's a few more instances of uritemplate bug fixing too.
