osf.io icon indicating copy to clipboard operation
osf.io copied to clipboard

[Feature] Fix mithril redraws issues btn logs and tb filebrowser [OSF-8587]

Open fabmiz opened this issue 8 years ago • 1 comments

Purpose

To solve an issue described in https://github.com/CenterForOpenScience/osf.io/pull/7277, logs and tb filebrowser mounts where put in same mithril redraw.

Use m.request with background : true to prevent mithril redraws upon promise return, while keeping part of solution in https://github.com/CenterForOpenScience/osf.io/pull/7277

Changes

  • Have logFeed use with m.request with background : true
  • Remove m.startComputation/m.endComputation pair

QA Considerations

  • Test this with a project that has lots of files, folders, and maybe several addons enabled. The point is to make the filebrowser take long to load. This fix should make it so the logs load independently and depending on the complexity/size of the files/folder/addons, logs may finish loading earlier.
  • Check if the 'new component' button is only enabled when the filebrowser on the left is done rendering.
  • Check if you can create new component or link projects while logs are loading.

Before/After

More of a performance fix, hard to notice/capture the diff before/after. though, logs should render a little faster than before.

Ticket

OSF-8587

fabmiz avatar Sep 07 '17 19:09 fabmiz

@fabmiz Could you make a version of this based on Master? Steve is interested in hotfixing it.

brianjgeiger avatar Sep 18 '17 16:09 brianjgeiger