osf.io icon indicating copy to clipboard operation
osf.io copied to clipboard

[ENG-8740] Ability to delete a file from a registration via admin

Open mkovalua opened this issue 4 months ago • 4 comments

Purpose

Frequently users inadvertently include personal identifying information in files associated with Registrations. It becomes imperative for these files to be removed as soon as possible. While any solution to https://openscience.atlassian.net/browse/ENG-8547 would also solve this issue, the most important piece of that analysis is the removal of the file containing the personal identifying information. This function is currently only able to be completed by a Cloud engineer, enabling this function in the admin app would reduce Cloud engineer time and allow for faster resolution to user mistakes with including personal identifying information in files.

Changes

implementation of business logic and UI to delete specified file by guid

image

https://github.com/user-attachments/assets/206b260d-00d2-46e1-806a-44c7486a5927

QA Notes

  1. After registration is archived file should be deleted from registration files UI tab on admin panel delete action
  2. After registration is archived file should be deleted from registration overview UI tab on admin panel delete action
  3. After registration is archived file should not be deleted from registration associated project

What are the areas of risk?

Any concerns/considerations/questions that development raised?

image

not confident about

reg.registration_responses = reg.schema_responses.latest('created').all_responses
reg.registered_meta[reg.registered_schema._id] = reg.expand_registration_responses()

usage

it looks like

image

reg.registered_meta[reg.registered_schema._id] may be used properly only for DraftRegistration for now

and reg.schema_responses.latest('created') will raise Not Exist error if there is no record

maybe try: except approach is ok, maybe some additional logic is expected

Documentation

Side Effects

Ticket

https://openscience.atlassian.net/browse/ENG-8740

mkovalua avatar Sep 08 '25 13:09 mkovalua

@mkovalua Could you rebase this onto the latest feature/pbs-25-19 branch?

adlius avatar Sep 18 '25 16:09 adlius

@mkovalua Could you rebase this onto the latest feature/pbs-25-19 branch?

adlius avatar Sep 18 '25 16:09 adlius

hi @adlius, I have resolved merge conflicts with feature/pbs-25-19

mkovalua avatar Sep 19 '25 15:09 mkovalua

LGTM

antkryt avatar Nov 21 '25 12:11 antkryt