cashscript icon indicating copy to clipboard operation
cashscript copied to clipboard
verified publisher icon CashScript

feat: Add ChaingraphNetworkProvider

Open PHCitizen opened this issue 1 year ago • 5 comments

closes #249

PHCitizen avatar Jan 28 '25 02:01 PHCitizen

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cashscript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 1:09pm

vercel[bot] avatar Jan 28 '25 02:01 vercel[bot]

Thanks for the PR @PHCitizen 😄

One thing I noticed is that there's no extra tests for the new ChaingraphNetworkProvider In the folder test you'll see /e2e/network, here we have tests for the network providers like FullStack.test.ts So it would be great to have similar automated tests for the new ChaingraphNetworkProvider

Also could you change the target branch from master to next, this is were all the ongoing development happens for upcoming releases.

mr-zwets avatar Jan 28 '25 08:01 mr-zwets

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

vercel[bot] avatar Feb 01 '25 12:02 vercel[bot]

Hey @PHCitizen thank you for creating this PR (and the other draft PR). We're currently busy with the debugging support for the advanced transaction builder and additional features for v0.11, so we will take a deeper look into your PR(s) when that is finished. You can follow that progress in #230, #257 and milestone v0.11. We expect to release that version around the May 15th upgrade or a little bit after.

rkalis avatar Feb 04 '25 10:02 rkalis

One upstream issue is that my chaingraph-ts library doesn't are not filter the results by network meaning getUtxos would also return chipnet utxos

created an upstream issue for this https://github.com/mr-zwets/chaingraph-ts/issues/1

mr-zwets avatar Mar 10 '25 13:03 mr-zwets