Carter Fendley

Adding a note about the urgency of this change. #11246 introduced a bug which would have been caught by the sample tests if the driver / launcher had been built...

@HumairAK That the PR introduced a bug in the main branch. @zazulam is the expert there, I think he will be on the community call tomorrow and will have better...

Okay so the PR above starts work on this. **Long term we should probably be using something different than `kubectl patch` commands** but this gets things working to stop any...

@dimaqq I don't think this is your issue, but mine was that I was requesting too much memory. Specifically I was passing `--memory 8096` (copied from a previous minikube command)...

> Maybe worth adding just one unit test to verify if setting both env vars will generate the Workflow yaml with the new flags. Will do :)

Okay in [this commit](https://github.com/kubeflow/pipelines/pull/11278/commits/714901fc4166b9bdeb629ff31d771eb49b1ef89f) I have updated the [compiler tests](https://github.com/kubeflow/pipelines/blob/714901fc4166b9bdeb629ff31d771eb49b1ef89f/backend/src/v2/compiler/argocompiler/argo_test.go#L79-L87) with logic to optional take in environment variables and set them: ```go if tt.envVars != nil { for _, envVar...

@hbelmiro Yes, as noted by Greg, we want to make sure that the main container for the `-impl` pod also is setup to be configurable. Had some discussion on slack...

@hbelmiro Thanks for the ping, I'll slack you real quick.

Thanks for the bump, will provide update soon. Apologies for the delay. On Fri, Jan 10, 2025 at 11:47 Humair Khan ***@***.***> wrote: > @CarterFendley , just a bump, can...

Modifications have been made to address [this issue](https://github.com/kubeflow/pipelines/pull/11278#issuecomment-2423229241) found by @gregsheremeta, thanks for pointing that out! Since the instance was one where the **driver** sets the log level of the...