forge icon indicating copy to clipboard operation
forge copied to clipboard

Limit edition range for Adventure drafts

Open tehdiplomat opened this issue 3 months ago • 5 comments

tehdiplomat avatar Oct 12 '25 03:10 tehdiplomat

Looks good, but needs a conflict resolution, it seems...

Agetian avatar Nov 01 '25 17:11 Agetian

Oh, I didn't notice this was open when I added it in #9096. Close as redundant then?

Jetz72 avatar Nov 21 '25 21:11 Jetz72

I noticed the predicates in both are different.

This one, each predicate subsequently negates the preceding one, while the one in #9096 each predicate just negates the "standard" set predicate, so it looks like the "vintage" predicate will still have possibility of "modern" sets in it, and the "modern" predicate will still have possibility of "pioneer" sets in it. etc.

jumpinjackie avatar Nov 22 '25 04:11 jumpinjackie

Yes, I discussed the reasoning behind doing it that way in the other PR. We can still change it if we want, though if anything, it might be easier to drop the random format filters in favor of a single weighted selection that we can bump up and down based on edition characteristics.

Jetz72 avatar Nov 22 '25 16:11 Jetz72

Ah, point taken.

jumpinjackie avatar Nov 23 '25 00:11 jumpinjackie