forge icon indicating copy to clipboard operation
forge copied to clipboard

Timestamp rework

Open Hanmac opened this issue 3 years ago • 1 comments

Draft for now, i need to update more Effects, so that the WrappedAbility Check can be removed

The Main reason for this MR, Split Timestamp into:

  • GameTimestamp that is used by the Rules when an Card becomes an new Object
  • LayerTimestamp that is used when the Rules talk about a Card getting a new timestamp, only used for Static Layer Effects

Also

  • For Player, add a new check "isInGame" which means the Player has neither lost, nor won (in case of Limited Influence)
  • Also More Effects should check for GameTimestamp in Effect so it is checked for Triggered objects
  • canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

Hanmac avatar Apr 22 '22 11:04 Hanmac

Had the AI play around 50 games on this branch, seems stable so far

If we get the old issues back I think there should be some with timestamp stuff that might get solved

Let me know if I should test for anything else

tool4ever avatar Apr 24 '22 14:04 tool4ever

canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

I need rules check if that is true or not. It may or may not depends on the lines of code if they are on the same line in the oracle.

Hanmac avatar Nov 25 '22 14:11 Hanmac

probably need to check for cards that got released after i started working on this for their Triggered values

Hanmac avatar Jun 18 '23 05:06 Hanmac

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

github-actions[bot] avatar Sep 13 '23 09:09 github-actions[bot]