dcx-react-library icon indicating copy to clipboard operation
dcx-react-library copied to clipboard

Group and Radio are confusing names

Open daniele-zurico opened this issue 3 years ago • 0 comments

Screenshot 2022-10-07 at 13 23 40

Screenshot 2022-10-07 at 13 23 40

  • Radio doesn't make sense to exist on his own because you'll never have a radio with one element. So actions are:

  • [ ] Remove the storybook documentation for radio

  • [ ] DO NOT Remove the FormRadio component however on top put a comment saying that this is deprecated and will not be used anymore

  • Form instead will be split into 2 components. So actions are:

  • [ ] Create a new Component called FormRadio (that is exactly the same as the Group with the only difference being that type will be hardcoded with the value of radio, i.e. type=radio

  • [ ] Create the documentation called FormRadio in storybook

  • [ ] Create a new Component called FormCheckbox (that is exactly the same of Group with the only difference being that type will be hardcoded with the value of checkbox, i.e. type=checkbox

  • [ ] Create the documentation called FormCheckbox in storybook

  • [ ] Remove the storybook documentation called Group

  • [ ] Remove the component called Group

This ticket is pretty much a refactor that will simplify the usage

Please follow the following instruction to create the new branch:

git checkout release/0.6
git pull
git checkout -b 'feature/radio-and-checkbox'

daniele-zurico avatar Oct 07 '22 12:10 daniele-zurico