pywrap icon indicating copy to clipboard operation
pywrap copied to clipboard

GeomLib_Tool Parameter result U is inaccessible

Open voneiden opened this issue 3 years ago • 3 comments

The current OCP GeomLib_Tool.Parameter_s function stores the computed result in the 4th reference argument U and returns a bool indicating success.

https://github.com/CadQuery/OCP/blob/036b08c136528fecb6df570453be218df0ed72f6/opencascade/GeomLib_Tool.hxx#L51

Return value should probably be Tuple[bool, float] or something along those lines.

voneiden avatar Jul 02 '22 10:07 voneiden

In the draft PR #46 I've presented one approach. Any thoughts on if this is worth pursuing further? If yes, I can volunteer to try to dig out if this impacts cadquery codebase in any way.

voneiden avatar Jul 02 '22 15:07 voneiden

Also I suppose if we do pursue this, the solution should support any return value, not just a hardcoded Standard_Boolean?

voneiden avatar Jul 02 '22 15:07 voneiden

Pls open the issue in the OCP repo.

sob., 2 lip 2022, 17:35 użytkownik Matti Eiden @.***> napisał:

Also I suppose if we do pursue this, the solution should support any return value, not just a hardcoded Standard_Boolean?

— Reply to this email directly, view it on GitHub https://github.com/CadQuery/pywrap/issues/45#issuecomment-1172917289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKVOYTI4YGYQ6ZTWHJSK5TVSBOVJANCNFSM52O3QN7A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

adam-urbanczyk avatar Jul 02 '22 17:07 adam-urbanczyk