json-rules-engine icon indicating copy to clipboard operation
json-rules-engine copied to clipboard

Expose UndefinedFactError and add test

Open rdvoskin-recur opened this issue 4 years ago • 1 comments

PROBLEM

  • UndefinedFactError is not exported which makes it hard to catch
  • UndefinedFactError.code value is not exported with makes it hard to detect
  • No tests exist for UndefinedFactError

SOLUTION

  • Export UndefinedFactError and UndefinedFactErrorCode
  • Add unit test
  • Add babel plugin for Error to make instanceof work properly with babel

rdvoskin-recur avatar Mar 03 '22 17:03 rdvoskin-recur

@CacheControl I look forward to your review. This is an excellent library, and I want to do my part to support it :)

rdvoskin-recur avatar Mar 03 '22 17:03 rdvoskin-recur