CSwala-android icon indicating copy to clipboard operation
CSwala-android copied to clipboard

Fix #164: Enhance and fix WebActivity as default to display webpages

Open GowthamGoush opened this issue 4 years ago • 7 comments

Explanation

Fixes #164:

  • Made Job Portal open inside web activity.
  • Enhanced web activity with a toolbar.
  • Added option to close, open desktop site and open zoom controls under the toolbar.

Checklist

  • [x] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • [x] The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • [x] The PR does not contain any unnecessary auto-generated code from Android Studio.
  • [x] The PR does not break any part of the existing code.
  • [x] The PR creator have carefully read & adher to the contributing guidelines of the project.
  • [x] The PR is made to the branch that's called "develop".
  • [x] The PR is made from a branch that is up-to-date with "develop".

GowthamGoush avatar Apr 28 '21 17:04 GowthamGoush

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

GowthamGoush avatar Apr 30 '21 08:04 GowthamGoush

Alright, I'll make those changes. Also, I just failed to mention that the desktop view wasn't working for me even after referring to the documentation and articles. Could you mention some resources, or shall I place a dummy toggle button as of now?

OK I'll share the resources

riturajjain2000 avatar Apr 30 '21 10:04 riturajjain2000

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

riturajjain2000 avatar Apr 30 '21 15:04 riturajjain2000

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1

Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

GowthamGoush avatar May 03 '21 16:05 GowthamGoush

Use this String in place of your - Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.1 Also to check your specific user agent check - https://www.whoishostingthis.com/tools/user-agent/

Extremely sorry for the delay. I followed what you had mentioned above, but still, it didn't work for me. I just wish to know if this not worked for me alone.

I did not tried it , but this is the best available solution I found on the net

riturajjain2000 avatar May 04 '21 09:05 riturajjain2000

As of now, shall I skip this and implement the rest of the features?

GowthamGoush avatar May 07 '21 13:05 GowthamGoush

As of now, shall I skip this and implement the rest of the features?

Ok leave the PR as it is , I'll merge it later

riturajjain2000 avatar May 08 '21 09:05 riturajjain2000