Carter Francis

Results 597 comments of Carter Francis

> The `to_marker` function is a good idea! And having a `plot` function which just plots the marker should be possible as well, however the plotting code can be a...

> With regards to the `plot` function, I can have a look at that at some point. Probably after this current release. I have done some previous work with the...

@ericpre is there a reason that the ragged property for a signal needs to be set rather than making the ragged property more of a strict type checking. If the...

If anyone has time to review this that would be much appreciated. I tried to change as little as possible to how hyperspy functions with this and the overall code...

Failing tests are related to equality in the traits package. `ax.size == t.Undefined` is evaluating to False instead of True for the VectorDataAxis on some of the test instances. Does...

@ericpre that sounds like a good idea. I can resubmit a PR with just the changes to the Axes, axes manager and the signal. I'll see what I can do...

Maybe it's best to start with the use cases: 1: Ragged signal of vectors with constant number of columns. (Think something like the results from `find_peaks` 2: Non-ragged signal with...

@ericpre I've looked over this a little bit more and I think that the best course of action is to create a new class `ColumnAxis`. The idea being that an...

@ericpre Sorry I think this was maybe overly confusing. I was still trying to figure things out. Basically I tried to figure out the non ragged case first with the...

I don't have anything to add except for to ping @jat255 as well. I know he works a lot with metadata so he might have some experience/good ideas for standardizing...