NetDissect-Lite icon indicating copy to clipboard operation
NetDissect-Lite copied to clipboard

Scipy.misc (latest version), typo and type

Open RR5555 opened this issue 6 years ago • 1 comments

Disclaimer: I did not go through all the code yet, plus not familiar with thread manipulation and such in python, and I did not run the code yet (some compatibility mishaps to correct with scipy.misc for imresize in the latest version of the libs and checking the code including the file manipulation still hold me from doing so).

Changed:

from PIL import Image
# mask = imresize(feature_map, (concept_map['sh'], concept_map['sw']), mode='F')
mask = np.array(Image.fromarray(feature_map).resize((concept_map['sh'], concept_map['sw'])))

(Did not run that version, so maybe it is breaking the code or buggy)

There seems to be a typo in that line: https://github.com/CSAILVision/NetDissect-Lite/blob/2163454ebeb5b15aac64e5cbd4ed8876c5c200df/loader/data_loader.py#L593

Then, without any understanding of the underlying program but with pylint, not sure if 'cancel_join_thread' can work on a pool, 'result' would appear compatible type-wise (as in the pytorch code for worker it was applied on data_queue), but not even sure if it makes any sense (plus initially outside of the loop, so probably not meant for 'result').

RR5555 avatar Sep 04 '19 07:09 RR5555

Don't know if it helps or not, but I created conda env with:

conda install scipy==1.0.0 (must be installed first) conda install pytorch==1.2.0 torchvision==0.4.0 cudatoolkit=10.0 -c pytorch

and Net-Dissection-Lite worked perfect (on linux, never successed on windows).

cyizhuo avatar Apr 26 '20 12:04 cyizhuo