Chris Bridge

Results 146 comments of Chris Bridge

Hi @apint0-media , thanks for trying out highdicom. First of all, please note that the correct way to create the DICOM SEG in a situation like this where you have...

Thanks @apint0-media. I am wondering whether this may have something to do with the time dimension. Unfortunately the way that segmentation frames are indexed in segmentations is extremely flexible and...

Doctests has been set up in #165 to catch errors in docstrings. However this does not catch errors in the RST examples, so leaving this open

A note here that pydicom 2.3.0 has a lot of new functionality to help us here, we just need to figure out how to best make use of it

Thanks for filing the bug report, @adamvonpaternos ! Though this seems like a simple bug, it actually gets at a more fundamental point... If all the frames are empty, and...

Actually @adamvonpaternos can you please confirm whether you are encountering this issue when there are no empty frames or all empty frames? Your text "if there are no empty frames...

To be clear, the current behaviour of highdicom when it receives a segmentation pixel array that is all zeros (avoiding the potentially confusing term "empty") is as follows: - if...

(also, before we decide on an approach, I would like to get confirmation from @adamvonpaternos that we haven't miunderstood what's leading to the problem he's having. It's possible that he's...

My personal leaning is to continue to allow segmentations with no "positive" pixels. The reason being that otherwise it becomes difficult to differentiate between a segmentation that was run and...

Thanks for the reply, these are good points. I will play around with creating a `DICOMwebUriClient`