WASP icon indicating copy to clipboard operation
WASP copied to clipboard

Filter dates that are not within target date +/- synthalf

Open jmichel-otb opened this issue 6 years ago • 5 comments

This PR adds date filtering when command-line parameters --date and --synthalf are both set.

Dates outside of date +/- synthalf are ignored by the processor.

jmichel-otb avatar Dec 10 '19 15:12 jmichel-otb

Merci Julien, Was it not the case before ? Olivier

olivierhagolle avatar Dec 10 '19 16:12 olivierhagolle

According to @petket-5 no : all input xml are processed for some steps, even if the algorithm might set a very small weight for them.

If I understand well what @petket-5 told me, the optimal use is currently to select dates within the desired range beforehand and pass this selection to --input. With this PR, you can pass 3 years of data to --input, and all dates that do not fall in desired range will be ignored.

jmichel-otb avatar Dec 10 '19 16:12 jmichel-otb

@olivierhagolle This is correct. The products outside of a given synthalf could still be used as an input to WASP, even if their average impact weight was low (Specified in the weightdatemin parameter).

With this PR we remove this possibility as it allows users a clearer usage of WASP for a fixed window of products. You can directly run WASP on a whole time series of L2 products without 'worrying' that your 3A syntheses mix up uncontrollably.

I will try to check and merge the code this week,

Peter

petket-5 avatar Dec 10 '19 17:12 petket-5

Thanks Peter and Jullien, I was not aware of that, and I prefer the new way of handling the dates ! Olivier

olivierhagolle avatar Dec 10 '19 17:12 olivierhagolle

Thanks @petket-5 , if you are worried about loosing a feature, we can add a command-line switch to enable/disable this behavior.

jmichel-otb avatar Dec 11 '19 08:12 jmichel-otb