bcda-app icon indicating copy to clipboard operation
bcda-app copied to clipboard

BCDA's OAuth Token Response has String expires_in

Open suyashkumar opened this issue 3 years ago • 0 comments

Hi there! I noticed that BCDA's OAuth Token response provides a string value for the expires_in parameter.

If I'm reading the OAuth RFC correctly, expires_in should be a numeric value instead of a string value (e.g. not quoted in JSON).

Functionally what that means is that expiresIn needs to be returned as a numeric here: https://github.com/CMSgov/bcda-app/blob/5a35685fe21354972d7a966082e4b15aa2e411ee/bcda/auth/api.go#L44.

Let me know if I can help.

Cheers, -Suyash

suyashkumar avatar Nov 09 '22 04:11 suyashkumar