adminterface icon indicating copy to clipboard operation
adminterface copied to clipboard

test: add test for input.js

Open dulerong opened this issue 4 years ago • 2 comments

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [x] Other (please describe):

What is the current behaviour?

No test for input.js

Issue Number(s): N/A

What is the new behaviour?

  • add test for input.js

Other information

N/A

dulerong avatar Jan 03 '22 11:01 dulerong

@samuelbruk Hi there! Hope you had a great new year.

I tried making a pull request and experienced the following problem in CI: Run Linters -> Set up Ruby

The error occurred in bundle install and error message is as below:

  /opt/hostedtoolcache/Ruby/3.1.0/x64/bin/bundle config --local path /home/runner/work/adminterface/adminterface/vendor/bundle
  Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
  /opt/hostedtoolcache/Ruby/3.1.0/x64/bin/bundle config --local deployment true
  Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
  Cache key: setup-ruby-bundler-cache-v3-ubuntu-20.04-ruby-3.1.0-Gemfile.lock-471f0599493702b07245647a321da0c699cf939845f7b37a3135c3b60408f01d
  /opt/hostedtoolcache/Ruby/3.1.0/x64/bin/bundle install --jobs 4
  Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
  Fetching gem metadata from https://rubygems.org/.........
  nokogiri-1.12.5-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
  incompatible with the current version, ruby 3.1.0p0
  Took   3.37 seconds
Error: The process '/opt/hostedtoolcache/Ruby/3.1.0/x64/bin/bundle' failed with exit code 5

Just for reference, the very last commit, on 2021-Nov-26, where the CI ran without a problem, the bundle install step had the following message.

 /opt/hostedtoolcache/Ruby/3.0.3/x64/bin/bundle config --local path /home/runner/work/adminterface/adminterface/vendor/bundle
  /opt/hostedtoolcache/Ruby/3.0.3/x64/bin/bundle config --local deployment true
  Cache key: setup-ruby-bundler-cache-v3-ubuntu-20.04-ruby-3.0.3-Gemfile.lock-471f0599493702b07245647a321da0c699cf939845f7b37a3135c3b60408f01d
  Received 0 of 62928392 (0.0%), 0.0 MBs/sec
  Received 62928392 of 62928392 (100.0%), 32.5 MBs/sec
  Cache Size: ~60 MB (62928392 B)
  /usr/bin/tar --use-compress-program zstd -d -xf /home/runner/work/_temp/061aa4a0-f744-4241-b129-173f111a201d/cache.tzst -P -C /home/runner/work/adminterface/adminterface
  Cache restored successfully
  Found cache for key: setup-ruby-bundler-cache-v3-ubuntu-20.04-ruby-3.0.3-Gemfile.lock-07758909aa95e1b90dd852df33706847bd1dbd7ca7ab45389ce36df890f6341b
  /opt/hostedtoolcache/Ruby/3.0.3/x64/bin/bundle install --jobs 4
  Fetching gem metadata from https://rubygems.org/.........
  Using rake 13.0.3

I'm not sure how this error came about, but seems like the following caused the error.

Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

 nokogiri-1.12.5-x86_64-linux requires ruby version < 3.1.dev, >= 2.5, which is
  incompatible with the current version, ruby 3.1.0p0

Could you please let me know what you think about this error? Thank you.

dulerong avatar Jan 03 '22 11:01 dulerong

@samuelbruk Hi there! Hope you had a great new year.

I tried making a pull request and experienced the following problem in CI: Run Linters -> Set up Ruby

Hello @dulerong, hope you had a wonderful holiday season as well.

Looking at it on the surface, it seems the Ruby version is incompatible with nokogiri. I'll be taking a look shortly.

samuelbruk avatar Jan 04 '22 19:01 samuelbruk