oceanmesh icon indicating copy to clipboard operation
oceanmesh copied to clipboard

Added read_fort14.py

Open liesvyvall opened this issue 1 year ago • 4 comments

to parse fort.14 mesh files, inspired by the methodology used in the OceanMesh2D MATLAB repository

liesvyvall avatar Jan 04 '25 20:01 liesvyvall

Should this be part of a reader/writer class instead of a standalone function?

krober10nd avatar Jan 04 '25 22:01 krober10nd

Maybe we need a reader/writer, a mesh_generator and a plot classes. Or we can put it in a separate class cause this is not related to the main objective of ocean mesh (create mesh)?

liesvyvall avatar Jan 05 '25 17:01 liesvyvall

Maybe we need a reader/writer, a mesh_generator and a plot classes. Or we can put it in a separate class cause this is not related to the main objective of ocean mesh (create mesh)?

Good suggestion while it's not the purpose of this library it's an essential utility. I'm in favor of creating two additional classes: one dedicating to plotting meshes (similar to msh.plot() in MATLAB) and a reader/writer for fort14 and 2dm format.

krober10nd avatar Jan 05 '25 18:01 krober10nd

Please rebase with the latest master. I think these functions should be integrated into a class called io or something like that.

krober10nd avatar Jan 20 '25 16:01 krober10nd