cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Kinetic Surface Reconstruction

Open soesau opened this issue 2 years ago • 29 comments

Kinetic Surface Reconstruction

Complementing the Kinetic Shape Partition package with the reconstruction pipeline described in the original paper.

  • Affected package(s): Kinetic Shape Partitioning and Kinetic Surface Reconstruction
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any):
  • Link to compiled documentation: doc
  • License and copyright ownership: GeometryFactory/Inria

link to mirrored PR

soesau avatar Dec 05 '23 09:12 soesau

/build:v0

soesau avatar Dec 05 '23 09:12 soesau

There was an error while building the doc:

/home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/PackageDescription.txt:8: warning: image file kinetic_logo.png is not found in IMAGE_PATH: assuming external image.

https://github.com/CGAL/cgal/actions/runs/7098965153

github-actions[bot] avatar Dec 05 '23 09:12 github-actions[bot]

/build:v0

soesau avatar Dec 05 '23 09:12 soesau

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/Documentation/packages.txt:1078: warning: image file name pkg-small.png is ambiguous.
Possible candidates:
   /home/runner/work/cgal/cgal/Documentation/doc/Documentation/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Polygonal_surface_reconstruction/doc/Polygonal_surface_reconstruction/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Weights/doc/Weights/fig/pkg-small.png
   /home/runner/work/cgal/cgal/Cone_spanners_2/doc/Cone_spanners_2/fig/pkg-small.png

https://github.com/CGAL/cgal/actions/runs/7099045850

github-actions[bot] avatar Dec 05 '23 10:12 github-actions[bot]

/build:v0

soesau avatar Dec 05 '23 10:12 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

github-actions[bot] avatar Dec 05 '23 10:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 07 '23 15:12 soesau

There was an error while building the doc:

error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Scale_space_reconstruction.tag' does not exist or is not a file. Skipping it...
error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Poisson_surface_reconstruction.tag' does not exist or is not a file. Skipping it...

https://github.com/CGAL/cgal/actions/runs/7130192649

github-actions[bot] avatar Dec 07 '23 15:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 07 '23 15:12 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

github-actions[bot] avatar Dec 07 '23 15:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 11 '23 07:12 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

github-actions[bot] avatar Dec 11 '23 07:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 13 '23 13:12 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

github-actions[bot] avatar Dec 13 '23 13:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 14 '23 14:12 soesau

There was an error while building the doc:


https://github.com/CGAL/cgal/actions/runs/7210011668

github-actions[bot] avatar Dec 14 '23 14:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 15 '23 09:12 soesau

There was an error while building the doc:

/home/runner/work/cgal/cgal/Documentation/doc/Documentation/packages.txt:1088: warning: unable to resolve reference to 'PkgKineticShapePartition' for \ref command
error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Kinetic_shape_partition.tag' does not exist or is not a file. Skipping it...
/home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/PackageDescription.txt:18: warning: unable to resolve reference to 'PkgKineticShapePartition' for \ref command
/home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt:12: warning: unable to resolve reference to 'PkgKineticShapePartition' for \ref command
/home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt:54: warning: unable to resolve reference to 'Ksp_parameters' for \ref command

https://github.com/CGAL/cgal/actions/runs/7220275870

github-actions[bot] avatar Dec 15 '23 09:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 15 '23 09:12 soesau

There was an error while building the doc:

error: Tag file '/home/runner/work/cgal/cgal/build_doc/doc_tags/Kinetic_shape_partition.tag' does not exist or is not a file. Skipping it...
/home/runner/work/cgal/cgal/Kinetic_surface_reconstruction/doc/Kinetic_surface_reconstruction/Kinetic_surface_reconstruction.txt:54: warning: unable to resolve reference to 'Ksp_parameters' for \ref command

https://github.com/CGAL/cgal/actions/runs/7220482761

github-actions[bot] avatar Dec 15 '23 09:12 github-actions[bot]

/force-build:v0

soesau avatar Dec 15 '23 13:12 soesau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v0/Manual/index.html

github-actions[bot] avatar Dec 15 '23 13:12 github-actions[bot]

I fixed some errors which could have been identified by compiling locally with clang inside Visual Studio. There are also lots of unused variables which are probably for debugging. So I did not remove them. Either comment, or add CGAL_assertion() to use them. There are also warnings in Orthtree but I guess the Orthtree will get upgraded to the one in the small feature.

afabri avatar Jan 17 '24 10:01 afabri

This testsuite shows many warnings and errors.

afabri avatar Jan 18 '24 07:01 afabri

/build:v1

afabri avatar Jan 18 '24 22:01 afabri

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/7908/v1/Manual/index.html

github-actions[bot] avatar Jan 18 '24 22:01 github-actions[bot]

@soesau Please carefully check 98171f5

I also have:

The following tests FAILED:
	  2 - execution   of  ksr_test (Failed)
	  6 - execution   of  ksr_reorientation (Failed)
	  8 - execution   of  ksr_regularization (Subprocess aborted)

and at least ksr_basic failing

sloriot avatar Apr 23 '24 09:04 sloriot

Successfully tested in CGAL-6.0-Ic-242

sloriot avatar May 15 '24 08:05 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar May 15 '24 15:05 github-actions[bot]

/build:v0

soesau avatar May 21 '24 07:05 soesau