cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Simpler implementation of Tet vs. Tri intersection

Open sloriot opened this issue 3 years ago • 5 comments

Easier version to maintain that is also fixing #6777

As the implementation is a new one I'm not sure we can backport it to release branches. @lrineau what do you think?

sloriot avatar Aug 01 '22 12:08 sloriot

I ran 30 times the test and the new version requires 22.99s while master version requires 23.29s.

sloriot avatar Aug 01 '22 12:08 sloriot

Easier version to maintain that is also fixing #6777

As the implementation is a new one I'm not sure we can backport it to release branches. @lrineau what do you think?

Why not? Do you fear new bugs? As far as I understand, the current implementation is already buggy, no?

lrineau avatar Aug 01 '22 14:08 lrineau

Easier version to maintain that is also fixing #6777 As the implementation is a new one I'm not sure we can backport it to release branches. @lrineau what do you think?

Why not? Do you fear new bugs? As far as I understand, the current implementation is already buggy, no?

I was not sure that a complete re-writing would be fine for a bug-fix release as the diff is large.

sloriot avatar Aug 02 '22 05:08 sloriot

Successfully tested in CGAL-5.6-Ic-39.

sloriot avatar Aug 03 '22 17:08 sloriot

@MaelRL do you want to review this PR or shall I merge it as is?

sloriot avatar Aug 03 '22 18:08 sloriot

@MaelRL do you want to review this PR or shall I merge it as is?

Ping, once you are available again.

lrineau avatar Aug 17 '22 11:08 lrineau

@MaelRL do you want to review this PR or shall I merge it as is?

Ping, once you are available again.

Ping again. @sloriot @MaelRL I let you discuss the status of this tested pull-request. For the moment, I keep it aside and do not merge it.

lrineau avatar Aug 29 '22 09:08 lrineau

Successfully tested in CGAL-5.6-Ic-65.

sloriot avatar Sep 09 '22 07:09 sloriot