cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Replace usage of Boost parameters with CGAL named function parameters

Open sloriot opened this issue 3 years ago • 3 comments

Replace the usage of boost parameter with CGAL named function parameters.

sloriot avatar Jun 04 '22 12:06 sloriot

/build:v0

sloriot avatar Sep 21 '22 15:09 sloriot

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6642/v0/Manual/index.html

github-actions[bot] avatar Sep 21 '22 15:09 github-actions[bot]

I was able to successfully compile:

  • CGAL-5.4/examples/Mesh_3
  • CGAL-5.5/examples/Mesh_3
  • CGAL-5.4/examples/Mesh_2
  • CGAL-5.5/examples/Mesh_2
  • CGAL-5.4/examples/Periodic_3_mesh_3
  • CGAL-5.5/examples/Periodic_3_mesh_3
  • https://github.com/meshpro/pygalmesh
  • https://github.com/fangq/iso2mesh (only cgalmesh part, hacking a bit the cmake script)

sloriot avatar Sep 21 '22 17:09 sloriot

/force-build:v0

sloriot avatar Sep 23 '22 13:09 sloriot

/force-build:v0

lrineau avatar Sep 26 '22 13:09 lrineau

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6642/v0/Manual/index.html

github-actions[bot] avatar Sep 26 '22 14:09 github-actions[bot]

/force-build:v0

sloriot avatar Sep 26 '22 18:09 sloriot

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6642/v0/Manual/index.html

github-actions[bot] avatar Sep 26 '22 18:09 github-actions[bot]

/force-build:v0

sloriot avatar Oct 03 '22 16:10 sloriot

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6642/v0/Manual/index.html

github-actions[bot] avatar Oct 03 '22 16:10 github-actions[bot]

Failing in CGAL-5.6-Ic-87

sloriot avatar Oct 11 '22 15:10 sloriot

Eventually successfully tested in CGAL-5.6-Ic-99!

sloriot avatar Oct 27 '22 08:10 sloriot

Successfully tested in CGAL-5.6-Ic-105

sloriot avatar Nov 04 '22 07:11 sloriot

All comments have been addressed, I remove the "not-yet-approved" flag.

sloriot avatar Nov 04 '22 07:11 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

github-actions[bot] avatar Nov 07 '22 09:11 github-actions[bot]

pushed force to remove unwanted files that were added. I checked that the diff between the new HEAD and the previous HEAD is empty.

sloriot avatar Nov 07 '22 09:11 sloriot

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

I have re-added Tested, because the diff of the force-push is null.

lrineau avatar Nov 07 '22 09:11 lrineau