cgal icon indicating copy to clipboard operation
cgal copied to clipboard
verified publisher icon CGAL

Improve C3T3 IO

Open maxGimeno opened this issue 5 years ago • 4 comments

Summary of Changes

Save/load edges in complex in c3t3 operator<</>>

Release Management

  • Affected package(s):Mesh_3
  • Issue(s) solved (if any): fix #2359

TODO

  • Wait for #5145 and then rework Edit: the implementation actually cannot rely on #5145

maxGimeno avatar Nov 09 '20 15:11 maxGimeno

@lrineau should this PR be closed?

sloriot avatar Sep 23 '21 08:09 sloriot

@lrineau should this PR be closed?

No. Now that we have abandoned #5145, this PR seems the right thing to do.

lrineau avatar Sep 23 '21 09:09 lrineau

@sloriot is this what you meant? The assertion added in commit f11cc0f fails I am checking why

janetournois avatar Jan 07 '22 09:01 janetournois

It fails because c3t3 (to be written) is output with its complex edges, so this is added to the end of the dump :

2
1 3 5
1 4 6

though c3t3_2 (loaded from the dump of c3t3) does not have complex edges, they have not been loaded.

janetournois avatar Jan 07 '22 10:01 janetournois