cgal icon indicating copy to clipboard operation
cgal copied to clipboard

Testsuite: Integrate some satellite projects

Open maxGimeno opened this issue 7 years ago • 8 comments

Modify testsuite scripts to add external projects to the tests if -x is given to autotest_cgal.

Release Management

  • Affected package(s):
  • Issue(s) solved (if any): fix #3433

maxGimeno avatar Nov 07 '18 12:11 maxGimeno

For now only SFCGAL is implemented.

maxGimeno avatar Nov 07 '18 12:11 maxGimeno

@maxGimeno We should test this one. Could you please refresh it?

sloriot avatar Aug 30 '21 08:08 sloriot

Successfully tested in https://cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-42.shtml

maxGimeno avatar Sep 02 '21 12:09 maxGimeno

Successfully tested in cgal.geometryfactory.com/CGAL/testsuite/results-5.4-Ic-42.shtml

That is not really tested: there should be at least one test platform that has TEST_XTERNAL=y.

lrineau avatar Sep 02 '21 13:09 lrineau

Actually, this PR does not implement the suggestion of https://github.com/CGAL/cgal/issues/3433. That is a different implementation.

lrineau avatar Sep 02 '21 13:09 lrineau

Actually, this PR does not implement the suggestion of #3433. That is a different implementation.

The proposal from #3433 was to modify the release creation, to embed a new test directory test/xternal_SFCGAL in the CGAL internal release. Here, that is autotest_cgal that is modified, but autotest_cgal is now barely used: all Linux platform uses Docker container and the test_cgal.py script, and most of the non-Linux platforms uses the script autotest_cgal_with_ctest.

lrineau avatar Sep 02 '21 13:09 lrineau

At the time this was developped, autotest_cgal_with_ctest did not exist. autotest_cgal is still used in the filter_testsuite, FYI

maxGimeno avatar Sep 02 '21 13:09 maxGimeno

Currently installed on Gauguin

maxGimeno avatar Sep 03 '21 12:09 maxGimeno