M2 - SBP review

Open NachoPal opened this issue 3 years ago • 1 comments

To avoid repeating myself I did not add a comment everywhere with similar issues.

As an extra suggestion, I would refactor some extrinsics. Some of them are too long and is difficult to follow what it happening. I think some of them can be split. I recommend you to use Pallet’s methods as helpers when the name of the method describes the action

Sep 23 '22 16:09 NachoPal

I have already replied or fixed all the suggestions or questions you raised above. Please take the time to check. If you have more suggestions, we are very willing to continue to improve them.

Oct 09 '22 07:10 ytqaljn

@NachoPal Look forward to your reply

Oct 19 '22 02:10 ytqaljn