ultimate_alarm_clock icon indicating copy to clipboard operation
ultimate_alarm_clock copied to clipboard

Added custom presets to timer

Open Vardhan-ysh opened this issue 11 months ago • 9 comments

Description

Added custom presets to timer. Now we can add and save custom presets in the timer section. Now users can add custom presets to timer and then save them, so they don't have to enter the same time every time. Have attached the screen record.

https://github.com/user-attachments/assets/f2553ce1-401a-4448-816a-c48c0d053f9d

Fixes #656

Checklist

  • [x] Tests have been added or updated to cover the changes
  • [x] Documentation has been updated to reflect the changes
  • [x] Code follows the established coding style guidelines
  • [x] All tests are passing

Vardhan-ysh avatar Feb 27 '25 22:02 Vardhan-ysh

Hi, @MarkisDev. Can you review this pr.

Vardhan-ysh avatar Mar 04 '25 03:03 Vardhan-ysh

@NishantSinghal19 can you check this pr and review it.

Vardhan-ysh avatar Mar 11 '25 17:03 Vardhan-ysh

@Vardhan-ysh The implementation seems fine, but I think we will have to work on the UI for this. It looks very different from what was proposed in the issue discussion, this UI will just end up being more confusing imo and users would think it's a bug.

MarkisDev avatar Mar 12 '25 16:03 MarkisDev

@MarkisDev , I tried following the ui I showcased but other things started glitching. I will try updating the UI for this page to look better.

Vardhan-ysh avatar Mar 12 '25 16:03 Vardhan-ysh

@Vardhan-ysh have you completed this implementation ?? If not I would like to work on it..

VatsalJain2004 avatar Mar 27 '25 05:03 VatsalJain2004

There's a doubt I want to ask of you @MarkisDev and @Vardhan-ysh that the present_button you created was actually an imitation of the pre-existing file , hover_preset_button.dart right ?? so we don't actually need your file and only need to work on the hover_.....dart file right ?

VatsalJain2004 avatar Mar 28 '25 05:03 VatsalJain2004

There's a doubt I want to ask of you @MarkisDev and @Vardhan-ysh that the present_button you created was actually an imitation of the pre-existing file , hover_preset_button.dart right ?? so we don't actually need your file and only need to work on the hover_.....dart file right ?

For the presets I only created the model file and changed the controller file. For the ui, I only edited the base files. I have been a little busy due to college exams so I have not been able to work on this. You can continue with this issue.The implementation part is working fine, you just need to update the ui for timer page so it is less confusing on how to use.

Vardhan-ysh avatar Mar 28 '25 05:03 Vardhan-ysh

Actually I have been thinking of adding new functionalities to it as well so I'll have to look into your code and see if i can reuse it in some way or not. Also presets_button.dart file is now shown as deleted in "View Reviewed Changes" so is it that this file is not really needed right !

Also is the file presets_button.dart even needed.. @Vardhan-ysh review this get back to me about this, please.

VatsalJain2004 avatar Mar 28 '25 05:03 VatsalJain2004

@Vardhan-ysh @VatsalJain2004 Hey guys, anyone working on it??

kushchoudhary98 avatar Apr 15 '25 15:04 kushchoudhary98