Bug: In updateAlarmProfiles function, currentProfile variable not utilized in logic

[abhivyakti2]

Description

Title: Refactor and Improve Usage of currentProfile in Alarm Profile Update Logic

Description:

I would like to raise an issue regarding the current implementation of the currentProfile variable in the alarm profile update logic. In updateAlarmProfiles, currentProfileName is fetched using storage.readProfile() and is used directly to filter alarms for updating. However, the variable currentProfile is declared using IsarDb.getProfile(currentProfileName) but is not utilized anywhere in the function. This creates unnecessary ambiguity and potential redundancy.

Suggested Solution:

• Refactor the function to use currentProfile to validate the existence of the profile before proceeding with updates.

Impact:

• Leaving unused or redundant variables in the codebase reduces maintainability and introduces unnecessary complexity. Ensuring clarity in the logic for updating alarm profiles will improve the quality of the code.

Request:

I would like to request the maintainers to assign this issue to me. I can work on refactoring this function to ensure a cleaner and more consistent implementation.

Thank you for your time and consideration!

Screenshots

[jyotiraditya-chauhan]

Hi @abhivyakti2 ,

I’d like to fix Bug #673 by refactoring updateAlarmProfiles to utilize currentProfile properly. Can you please assign this to me? Thanks!

Best,

[MarkisDev]

I have assigned this issue to you, you can refactor it. @abhivyakti2

[VatsalJain2004]

@abhivyakti2 have you solved this issue yet ? If not I can solve this issue.

[Anuj-Bhandari]

@MarkisDev what is the status of this bug ? I want to work on it , please assign this to me .