ultimate_alarm_clock icon indicating copy to clipboard operation
ultimate_alarm_clock copied to clipboard

Feature: Add custom presets to Timer.

Open Vardhan-ysh opened this issue 1 year ago • 7 comments

Description

Timer currently only allows 4 predefined presets (1min, 5min, 10min, 15min). We can give user the ability to add custom presets.

Screenshots

Vardhan-ysh avatar Jan 29 '25 10:01 Vardhan-ysh

I would like to work on this.

Vardhan-ysh avatar Jan 29 '25 10:01 Vardhan-ysh

Hey! Sure, could you give us a clearer idea on how you plan on implementing this so we can be on the same page?

MarkisDev avatar Feb 05 '25 17:02 MarkisDev

@MarkisDev , sure. I currently have in mind to implement something like this

https://github.com/user-attachments/assets/df2f77f0-0c8f-4e6d-8332-b8dd671ea0f0

I will keep the UI similar to the theme of ultimate alarm clock. This video just shows what I am working on. I am storing the created timer presets locally using the model.

I am currently already working on this and will share the UI and working before raising a pr.

Vardhan-ysh avatar Feb 05 '25 17:02 Vardhan-ysh

Hey @Vardhan-ysh this is already included in the application, when you click on the timer icon you will be displayed with option to set custom timer, I don't think this would be needed @MarkisDev what's your opinion on this?

ganidande905 avatar Feb 07 '25 19:02 ganidande905

@ganidande905 Yes, but you cannot add a custom preset. Only the predetermined 1, 5,10, and 15 minutes is present. For example if we need to set a 1 hour 30 min timer everyday, we would need to dial that number in everytime instead of setting a preset of 1 hour 30 min that we can use.I think adding this would make it more convenient than adding the same timer everytime.

Vardhan-ysh avatar Feb 07 '25 22:02 Vardhan-ysh

@Vardhan-ysh You can go ahead with the custom preset implementation. Would be a good addition to set quick timers. Please ensure you follow the same UI.

MarkisDev avatar Feb 20 '25 15:02 MarkisDev

@MarkisDev Can you review this pr.

Vardhan-ysh avatar Feb 28 '25 19:02 Vardhan-ysh