ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

Improve -out=report to show detected Teletext subtitle pages (Fixes #1034)

Open Rahul-2k4 opened this issue 1 month ago • 3 comments

This PR fixes Issue #1034, where running CCExtractor with -out=report does not list Teletext pages that contain possible subtitles, even though the same pages are correctly detected during normal extraction.

In report-only mode, CCExtractor skips Teletext PES packet processing because the encoder context (enc_ctx) is not created. Since subtitle-page detection happens inside Teletext packet parsing, no pages are recorded in seen_sub_page[], resulting in an empty Pages With Subtitles: field in the final report.

This PR enables Teletext detection in -out=report mode and ensures proper memory cleanup when the encoder is absent.

Rahul-2k4 avatar Dec 09 '25 07:12 Rahul-2k4

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit b293017...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 34/34

Congratulations: Merging this PR would fix the following tests:


All tests passing on the master branch were passed completely.

Check the result page for more info.

ccextractor-bot avatar Dec 09 '25 12:12 ccextractor-bot

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit b293017...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hardsubx 1/1
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 34/34

Congratulations: Merging this PR would fix the following tests:

  • ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed: Never
  • ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
  • ccextractor --hardsubx 1a0302f7fd..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 006fdc391a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 297a44921a..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 efbe129086..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 eae0077731..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 c6407fb294..., Last passed: Never
  • ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9..., Last passed: Never
  • ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf..., Last passed: Never

All tests passing on the master branch were passed completely.

Check the result page for more info.

ccextractor-bot avatar Dec 09 '25 12:12 ccextractor-bot

Hi, all tests are passing on the CI dashboard, but the CCExtractor CI bot hasn’t reflected the updated status on this PR. Is there a step I should take to trigger the bot again, or should I wait for it to sync? Let me know how I can help move this forward.

Screenshot 2025-12-09 211127 Screenshot 2025-12-09 211144 Screenshot 2025-12-09 211426 Screenshot 2025-12-09 211438

Rahul-2k4 avatar Dec 09 '25 15:12 Rahul-2k4