ccextractor icon indicating copy to clipboard operation
ccextractor copied to clipboard

[FEAT] Add `net` module in `lib_ccxr`

Open IshanGrover2004 opened this issue 1 year ago • 4 comments

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the contributors guide.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [x] I have considered, and confirmed that this submission will be valuable to others.
  • [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • [x] I give this submission freely, and claim no ownership to its content.
  • [x] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • [ ] I have never used CCExtractor.
  • [ ] I have used CCExtractor just a couple of times.
  • [ ] I absolutely love CCExtractor, but have not contributed previously.
  • [x] I am an active contributor to CCExtractor.

Currently WIP

Closes PR #1557

This PR adds networking primitives to send and receive captions across the internet. The networking functions are integrated into C codebase.

Rewrote of networking.c & networking.h file

Thanks to @elbertronnie who did this great work

IshanGrover2004 avatar Aug 14 '24 13:08 IshanGrover2004

@elbertronnie How did you test your code?

IshanGrover2004 avatar Aug 14 '24 14:08 IshanGrover2004

How did you test your code?

I don't remember the exact command I used but below are the general steps:

You will have to create a CCExtractor server program using the following command line argument: -tcp port: Reads the input data in BIN format according to CCExtractor's protocol, listening specified port on the local host. Keep this program running.

Then run another instance of CCExtractor where you specify the input files, etc, with the additional argument: -sendto host[:port]: Sends data in BIN format to the server according to the CCExtractor's protocol over TCP. For IPv6 use [address]:port

This will test the TCP implementation. I could not do for UDP as there is no way to send UDP packets in the program. Receiving UDP is still required since it is used in the Sample platform i guess. You will have to ask someone else for testing the UDP implementation.

elbertronnie avatar Aug 14 '24 14:08 elbertronnie

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 90f9f0a...:

Report Name Tests Passed
Broken 0/13
CEA-708 7/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 2/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 3/86
Teletext 0/21
WTV 0/13
XDS 1/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Aug 28 '24 10:08 ccextractor-bot

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 90f9f0a...:

Report Name Tests Passed
Broken 0/13
CEA-708 7/14
DVB 0/7
DVD 0/3
DVR-MS 0/2
General 2/27
Hauppage 0/3
MP4 0/3
NoCC 0/10
Options 3/86
Teletext 0/21
WTV 0/13
XDS 1/34

All tests passing on the master branch were passed completely.

NOTE: The following tests have been failing on the master branch as well as the PR:

Congratulations: Merging this PR would fix the following tests:


Check the result page for more info.

ccextractor-bot avatar Sep 01 '24 03:09 ccextractor-bot