beacon icon indicating copy to clipboard operation
beacon copied to clipboard

[Hike Screen] Unexpected behaviour when leader tries to change duration.

Open Aadeesh11 opened this issue 4 years ago • 6 comments

When the leader tries to change the duration, the dialogue that pops up does not provide an option to change duration.

DurationChangeError

I would like to work on this, please assign this to me.

Aadeesh11 avatar Dec 26 '21 15:12 Aadeesh11

Changing duration feature was planned to be implemented but wasn't implemented. I don't remember exactly if this was implemented on the backend or not. Check the backend schema here before working on this.

nb9960 avatar Dec 26 '21 17:12 nb9960

Thanks, will have a look.

Aadeesh11 avatar Dec 26 '21 17:12 Aadeesh11

Changing duration feature was planned to be implemented but wasn't implemented. I don't remember exactly if this was implemented on the backend or not. Check the backend schema here before working on this.

I had a look at the schema, as much as i understood, there was no mutation available to change the duration/time of the beacon. So should we remove the text that says "double tap to change duration" as it leads to unexpected UX and also the button that opens the dialogue maybe?

Aadeesh11 avatar Dec 26 '21 19:12 Aadeesh11

Instead of removing that part, comment it out (adding Todo: and the reason why it's not being implemented) as this feature is necessary and needs to be implemented later. And let's wait for this to get implemented on the backend first.

nb9960 avatar Dec 27 '21 15:12 nb9960

Thanks, will comment it out. 👍

Aadeesh11 avatar Dec 27 '21 17:12 Aadeesh11

Hey is this issue resolved? @nb9960 Would like to work on it if it hasn't

Rushour0 avatar Nov 25 '22 13:11 Rushour0