Flood_Mobile icon indicating copy to clipboard operation
Flood_Mobile copied to clipboard

A better way/method can be implemented to display the applied filter info.

Open Akshatji800 opened this issue 3 years ago • 23 comments

Is your feature request related to a problem? Please describe. The current way of displaying the applied filter info in the search bar can be improved/changed to make it look better.

Describe the solution you'd like To be proposed by the contributors who want to take up the issue by commenting on the issue.

Akshatji800 avatar Dec 11 '22 19:12 Akshatji800

please assign this issue to me.

sainideepanshu199 avatar Dec 13 '22 17:12 sainideepanshu199

Sure @sainideepanshu199 I am assigning you this issue. You can start by proposing the new suggested design and once the design gets approved then you can start coding/implementing it.

Akshatji800 avatar Dec 13 '22 17:12 Akshatji800

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide. image

sainideepanshu199 avatar Dec 13 '22 17:12 sainideepanshu199

I have installed Flood and qBittorrent but I am getting this error after following the contributing.md guide. image

@sainideepanshu199 there is some issue with qBittorent and flood which needs to be addressed and resolved until then you can use transmission instead of qBittorent. The setup is almost similar.

Akshatji800 avatar Dec 14 '22 16:12 Akshatji800

@sainideepanshu199 is there any progress on this issue?

Also @sainideepanshu199 were you able to solve the issue you were facing while setting up the project? If not then this is what you need to do to resolve the issue.

Uninstall the older version of flood u have by using the command sudo npm uninstall -g flood and install the latest but not released version by using the command sudo npm i -g @jesec/flood

Akshatji800 avatar Jan 10 '23 19:01 Akshatji800

i am very sorry for no work on this issue, due to some serious problems couldn't work on anything. but now i have started the setup again and i get a new issue while accessing app after opening web client from transmission app. image

could u please resolve this problem

sainideepanshu199 avatar Jan 18 '23 04:01 sainideepanshu199

For solve this error, while installing you have to install this Web Interface Option.

image

amitamrutiya avatar Jan 18 '23 17:01 amitamrutiya

can someone help me resolve this issue now, even after entering correct authentication details it shows failed login image

sainideepanshu199 avatar Jan 19 '23 05:01 sainideepanshu199

You have to enter a details that you use to create flood web-ui account. If it give this login error then try to uninstall flood using sudo npm uninstall -g flood and again try to install sudo npm i -g @jesec/flood and create new account. after create new flood account try to login with that details. I think this error comes because you enter wrong user details .

amitamrutiya avatar Jan 19 '23 05:01 amitamrutiya

Unassigning this issue to @sainideepanshu199 as there was no progress reported on the issue

Akshatji800 avatar Mar 04 '23 10:03 Akshatji800

Can you assign me this issue.

Ronakkkkk avatar May 02 '23 18:05 Ronakkkkk

Can you assign me this issue.

Hello @Ronakkkkk please let me know if you still want to work on this issue - if yes then I will assign this issue to you.

Akshatji800 avatar Sep 15 '23 22:09 Akshatji800

Please assign this issue to me.

tb-rules10 avatar Sep 27 '23 07:09 tb-rules10

Please assign this issue to me.

Please let me know what is your idea and how you are gonna improve it before I assign this issue to you.

Akshatji800 avatar Sep 27 '23 07:09 Akshatji800

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

image

tb-rules10 avatar Sep 27 '23 10:09 tb-rules10

I am thinking of combining Filters and Sort into a single bottom sheet and selected filters and sort by status can be seen below the search bar like this:-

image

Hey @tb-rules10, thanks for proposing this but the reason why this was not followed and approved initially itself is that we want to save as much space as we can on the main screen to show torrents. This is the reason why search bar, download speed etc are hidden and appears on top swipe. Please suggest something that aligns with our minimal screen space usage goal.

Akshatji800 avatar Sep 30 '23 19:09 Akshatji800

Hi @Akshatji800 its Aadarsh from FOSS 24. I think we can use chips to better portray the filtering options instead of the current radio selector. This proposal is also in line with using minimum space possible, since a user would have to scroll less.

Below is a skeleton of what the filter would look like, as the tracker list would be varying in size, the filter dialog will be scroll-able and will use wrap widget to handle devices of varying width.

flood

Nailsonseat avatar Mar 04 '24 15:03 Nailsonseat

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

Akshatji800 avatar Mar 05 '24 06:03 Akshatji800

Hey @Nailsonseat assigning this issue to you. But this issue is more about how we are gonna show the current filter selected in a better way. Currently it is shown in searchbar. I want you to work on that first.

Thank you Akshat, I will come back to you with an idea regarding this very soon.

Nailsonseat avatar Mar 05 '24 07:03 Nailsonseat

@Nailsonseat good observation but don't you think that removing filter icon and putting a dismiss button instead of it creates confusion that what actually complete is? The idea is good that there should be a way to dismiss the filter (it is definitely increasing the UX) but you need to think of a better UI.

Akshatji800 avatar Mar 05 '24 18:03 Akshatji800

@Nailsonseat good observation but don't you think that removing filter icon and putting a dismiss button instead of it creates confusion that what actually complete is? The idea is good that there should be a way to dismiss the filter (it is definitely increasing the UX) but you need to think of a better UI.

Good point, the user will not know if 'complete' is a filter or something else, will work on it. I deleted the original post because I wanted to show a good way to show sorting too along with filters. I will come to you will a new idea for both soon

Nailsonseat avatar Mar 05 '24 18:03 Nailsonseat

@Akshatji800 I have some new mock-ups or rather old ones because these designs are more closer to the original UI.

Initial state Selected state
Flood_5 Flood_6

Filters

I have two points with respect to the concern with confusion with dismiss button

  • The current mock-up has UI which is more intuitive in terms of deducing what the "complete" and the X button stands for, IMO.
  • The filter is located on far right where there is no other button near it, so I think the case for confusion would be even lower.

Sort

  • I included the sort button in a border to make it seem more like a button but I'm not sure about it, need you input on this.
  • Dismiss button is not needed for sorting as there is always a sort type that is always selected.
  • Currently whichever sort type you select , it always displays the A-Z icon, I think we can find all the 12 icons for the 12 sort types of sorts here

Do let me know if more improvements can be made here

Nailsonseat avatar Mar 06 '24 12:03 Nailsonseat

i found a potential implementation for the sort button straight from the material 3 website. Just imagine this with icons, and without the text in the button. The focus is the button not the drop down itself

https://github.com/CCExtractor/Flood_Mobile/assets/67797628/22a7d132-7993-451a-8df8-10439b99beab

I ll be on the lookout for better options

Nailsonseat avatar Mar 10 '24 13:03 Nailsonseat