LiquidBounce icon indicating copy to clipboard operation
LiquidBounce copied to clipboard

Fixed PlayerUseMultiplier event movement issue.

Open mems01 opened this issue 4 years ago • 2 comments

There has to be a better way of fixing this I'm pretty sure. Anyways, the problem had to do with the PlayerUseMultiplier event making the player move sideways only even if the forwards movement button (W) is pressed.

EDIT: Affects NoSlow module and perhaps any other module that might potentially use that event.

EDIT 2: Before: Pressing W/S + A/D https://streamable.com/z8bj17 After: Pressing W/S + A/D https://streamable.com/jfp0se

EDIT 3: Found a better way of fixing it, at least code size wise.

mems01 avatar Dec 02 '21 18:12 mems01

So apparently, as of 1/30/2022, multiconnect doesn't allow fluid push movement changes on versions lower than 1.13, even though the code should work without any problems.

Link to the issue that is causing this: https://github.com/Earthcomputer/multiconnect/blob/master/src/main/java/net/earthcomputer/multiconnect/protocols/v1_12_2/mixin/MixinEntity.java

mems01 avatar Jan 30 '22 15:01 mems01

So apparently, as of 1/30/2022, multiconnect doesn't allow fluid push movement changes on versions lower than 1.13, even though the code should work without any problems.

Link to the issue that is causing this: https://github.com/Earthcomputer/multiconnect/blob/master/src/main/java/net/earthcomputer/multiconnect/protocols/v1_12_2/mixin/MixinEntity.java

Fixed.

mems01 avatar Mar 25 '22 14:03 mems01