Clément Dumas comments

Results 87 comments of


                                            Clément Dumas

XML Reporter doesn't output stderr / stdin when there is a segfault

I'm using Clion. They use the `-r xml` option which causes the Error: ``` ➜ cmake-build-debug/tests -r xml -d yes --order lex test SIGSEGV - Segmentation violation signal Erreur de...

XML Reporter doesn't output stderr / stdin when there is a segfault

I tested on the `devel` branch and I have the same issue.

Thanks for your answer ! How do you add them to the [`PolicyFactory`](https://github.com/CodinGame/codingame-game-engine/blob/bce227bef7a8522f37aaa51a30c5c34b0fc07640/runner/src/main/java/com/codingame/gameengine/runner/Renderer.java#L901) as it's done for `TABLES` etc ?

Overflow is sanitized

If I import `org.owasp.html.CssSchema` and add ```java .and(CssSchema.DEFINITIONS) ``` at [this line of code](https://github.com/CodinGame/codingame-game-engine/blob/bce227bef7a8522f37aaa51a30c5c34b0fc07640/runner/src/main/java/com/codingame/gameengine/runner/Renderer.java#L905) will it works ?

Slide bar between editor and top level is not handy

Also sometimes the [top level just fill the whole screen for no reason](https://youtube.com/shorts/2nQmzkHpLTA?feature=share)

Added tokenizer_kwargs for LM init and allow user to pass custom config

Agreed! Sorry for the delay, rn I'm crunched byt deadlines so if anyone wants to fix this issue with another PR feel free to!

Added tokenizer_kwargs for LM init and allow user to pass custom config

@JadenFiotto-Kaufman added it, let me know if I should change something

Added tokenizer_kwargs for LM init and allow user to pass custom config

This PR now also fixes https://github.com/ndif-team/nnsight/issues/115

Added tokenizer_kwargs for LM init and allow user to pass custom config

Will do, sorry !