python-sc2 icon indicating copy to clipboard operation
python-sc2 copied to clipboard

Working ObserverAI and watch_replay.py

Open SoupCatcher opened this issue 3 years ago • 2 comments

This works for me:

python3 watch_replay.py some/replay.Sc2Replay

SoupCatcher avatar Jun 11 '22 17:06 SoupCatcher

Codecov Report

Merging #138 (6e10320) into develop (a870c62) will decrease coverage by 0.90%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    79.75%   78.85%   -0.91%     
===========================================
  Files           93       94       +1     
  Lines        12291    12434     +143     
===========================================
+ Hits          9803     9805       +2     
- Misses        2488     2629     +141     
Impacted Files Coverage Δ
sc2/observer_ai.py 0.00% <0.00%> (ø)
watch_replay.py 0.00% <0.00%> (ø)
sc2/bot_ai_internal.py 85.26% <0.00%> (+0.36%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a870c62...6e10320. Read the comment docs.

codecov-commenter avatar Jun 11 '22 18:06 codecov-commenter

I'd like to add a test that runs the watch_replay.py file in CI, so that I get notified every time I break the Observer class.

But for that I need a replay file. And that replay file might be incompatible with different python-sc2 versions, so I'd have to generate it in the CI. Additionally the replays may only be watched if the map file is available, but the docker image should have those. This is just me speaking my mind and what needs to be done before merging this PR.

BurnySc2 avatar Jan 09 '23 03:01 BurnySc2