AutoReconnect icon indicating copy to clipboard operation
AutoReconnect copied to clipboard

Update to 1.20.4 (Must be tested before merging)

Open TechPro424 opened this issue 2 years ago • 3 comments

Updates the mod to 1.20.4

TechPro424 avatar Dec 23 '23 10:12 TechPro424

you can just check what the game does, there are 2 linked functions in the jdoc comments (@see net.minecraft.client.QuickPlay#startRealms) correct, the lambda functions just set the screen in this case. I made it cleaner in my PR (that I did without checking if there already is one xD)

itsTyrion avatar Feb 12 '24 15:02 itsTyrion

you can just check what the game does, there are 2 linked functions in the jdoc comments (@see net.minecraft.client.QuickPlay#startRealms) correct, the lambda functions just set the screen in this case. I made it cleaner in my PR (that I did without checking if there already is one xD)

Thanks for pointing that out! Since there are 2 PRs, do you want me to close mine or are you ok with closing yours?

(Also I think you meant startSingleplayer there instead of startRealms)

TechPro424 avatar Feb 14 '24 14:02 TechPro424

Also fixed the reconnectMethod override in RealmsReconnectStrategy

TechPro424 avatar Feb 14 '24 15:02 TechPro424